fix(codewhisperer): handle out of bounds endLine #4254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctlai95
force-pushed
the
ctlai95/fix-out-of-bounds-exception
branch
from
9bef13b to
c70d371
Compare
|
mj632
approved these changes
Apr 9, 2024
rli
approved these changes
Apr 9, 2024
sarayev
pushed a commit
to sarayev/aws-toolkit-jetbrains
that referenced
this pull request
Apr 10, 2024
* fix(codewhisperer): handle out of bounds endLine * reduce code duplication
kumsmrit
pushed a commit
to kumsmrit/aws-toolkit-jetbrains
that referenced
this pull request
Apr 16, 2024
* fix(codewhisperer): handle out of bounds endLine * reduce code duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
If service returns out of bounds value for
endLine, the plugin fails withIndexOutOfBoundsExceptionwhen executingdocument.getLineEndOffset(). Force the value to be in the range (0, lineCount - 1) when calculating theendColvalue.Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.