feat(amazonq): add retries around APIs #4256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dhasani23
commented
Apr 10, 2024
There was a problem hiding this comment.
Everything deleted here was an unused string
dhasani23
commented
Apr 10, 2024
| codemodernizer.notification.info.modernize_partial_complete.title=Transformation partially successful! | ||
| codemodernizer.notification.info.submitted_project.content=Your project has been submitted for transformation. The code transformation process may take 10-30 mins depending on the size of your project. | ||
| codemodernizer.notification.info.submitted_project.title=Submitted Project | ||
| codemodernizer.notification.info.modernize_partial_complete.content=Transformation completed, but with build errors. The new code is not fully Java {0} compatible yet. You will need to fix changes yourself. You can view the changes by clicking View Diff below. |
There was a problem hiding this comment.
Already reviewed with PM, he wants this change to say "...but with build errors" instead of "partially completed"
mk-fan
reviewed
Apr 10, 2024
| @@ -254,7 +255,7 @@ class CodeModernizerSession( | |||
| throw AlreadyDisposedException("Disposed when about to create upload URL") | |||
| } | |||
| val clientAdaptor = GumbyClient.getInstance(sessionContext.project) | |||
| val createUploadUrlResponse = clientAdaptor.createGumbyUploadUrl(sha256checksum) | |||
| var createUploadUrlResponse = clientAdaptor.createGumbyUploadUrl(sha256checksum) | |||
There was a problem hiding this comment.
Should we move this into the try catch block?
for (attempt in 0..MAX_API_RETRIES) {
try {
var createUploadUrlResponse = clientAdaptor.createGumbyUploadUrl(sha256checksum)
clientAdaptor.uploadArtifactToS3(...)
} catch (e) {
...
}
}
|
Can you not use the SDK's builtin retry mechanism?
I would expect that to be explained in the PR description / commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
If an API fails, retry it once before notifying the user that it failed.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.