Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazonq): for /test internal users project payload limit increased to 1.5GB #5322

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

ashishrp-aws
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

for /test internal users project payload limit increased to 1.5GB

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashishrp-aws ashishrp-aws requested a review from a team as a code owner February 4, 2025 10:10
Copy link
Contributor

@laileni-aws laileni-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if possible increase the payload size to 2GB for testing with internal customers.

@@ -60,7 +63,12 @@ class CodeTestSessionConfig(
*/
fun overallJobTimeoutInSeconds(): Long = DEFAULT_CODE_SCAN_TIMEOUT_IN_SECONDS

fun getPayloadLimitInBytes(): Long = DEFAULT_PAYLOAD_LIMIT_IN_BYTES
fun getPayloadLimitInBytes(): Long =
if (isInternalUser(getStartUrl(project))) {
Copy link
Contributor

@rli rli Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this limit be fetched from the service instead?

Copy link
Contributor Author

@ashishrp-aws ashishrp-aws Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not right now. This needs service changes which would take time, so we used existing client options. This change is temporary right now for debugging the issue. we will make this permanent across the customers(external or internal) once we have data

@ashishrp-aws ashishrp-aws enabled auto-merge (squash) February 4, 2025 18:17
@ashishrp-aws ashishrp-aws merged commit 76f7518 into aws:main Feb 4, 2025
10 of 11 checks passed
ashishrp-aws added a commit to ashishrp-aws/aws-toolkit-jetbrains that referenced this pull request Feb 5, 2025
ashishrp-aws added a commit that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants