fix(amazonq): Adding payload manifest for payload limit errors. #5324
+110
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laileni-aws
approved these changes
Feb 5, 2025
ctlai95
approved these changes
Feb 5, 2025
jkuruba
reviewed
Feb 5, 2025
| @@ -98,6 +99,9 @@ class CodeWhispererUTGChatManager(val project: Project, private val cs: Coroutin | |||
| session.srcZipFileSize = codeTestResponseContext.payloadContext.srcZipFileSize | |||
| session.artifactUploadDuration = codeTestResponseContext.serviceInvocationContext.artifactsUploadDuration | |||
| val path = codeTestResponseContext.currentFileRelativePath | |||
| if (codeTestResponseContext.payloadContext.payloadLimitCrossed == true) { | |||
| fileTooLarge() | |||
There was a problem hiding this comment.
If FileTooLarge throws an exception, where does the manifest get uploaded?
There was a problem hiding this comment.
manifest is already uploaded to service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Our major failure reason is due to payload limit error. Especially for internal amazon users, we want to add file manifest in payload to help our debugging on service and client errors.
codewhispererCodeScanBuildPayloadBytestelemetry event which is unusedbuildPayloadSizefrom the payloadMetadata.Tested on Amazon Internal repositories, public github repositories for both python and Java languages
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.