docs(typescript-restrictions): clarify non-jsii deps #3995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
RomainMuller
suggested changes
Mar 13, 2023
gh-pages/content/user-guides/lib-author/typescript-restrictions.md
Outdated
Show resolved
Hide resolved
kaizencc
changed the title
|
@RyoshiKayo any chance you continue your work here and we get this in? |
mrgrain
reviewed
Nov 14, 2023
gh-pages/content/user-guides/lib-author/typescript-restrictions.md
Outdated
Show resolved
Hide resolved
mrgrain
approved these changes
Nov 14, 2023
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent about a day and a half trying to figure this out, so I thought I'd add a little clarification :)
tl;dr: I'm making a CDK Construct package that also includes a custom lambda handler. That handler takes on a non-jsii dep but I couldn't figure out why JSII kept trying to compile that non-jsii dep until I read
about 20 times.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.