Add User-Agent header and documentation #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Prometheus Connector," and the version of the Prometheus connector, has been added to the User-Agent header, before the current value in the User-Agent header, which is the AWS SDK and its version. Example from logs with DEBUG log-level: ``` User-Agent: Prometheus Connector/1.1.0 aws-sdk-go/1.35.7 (go1.21.1; darwin; arm64) ``` Also, details on what the `User-Agent` header value is for the Prometheus Connector has been added to the README.
forestmvey
pushed a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
* Add User-Agent documentation to README * Add User-Agent header value --------- Co-authored-by: Trevor Bonas <[email protected]>
forestmvey
pushed a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
* Add User-Agent documentation to README * Add User-Agent header value --------- Co-authored-by: Trevor Bonas <[email protected]>
forestmvey
pushed a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
* Add User-Agent documentation to README * Add User-Agent header value --------- Co-authored-by: Trevor Bonas <[email protected]>
forestmvey
pushed a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
* Add User-Agent documentation to README * Add User-Agent header value --------- Co-authored-by: Trevor Bonas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
"Prometheus Connector," and the version of the Prometheus connector, has been added to the User-Agent header, before the current value in the User-Agent header, which is the AWS SDK and its version.
Example from logs with DEBUG log-level:
Also, details on what the
User-Agentheader value is for the Prometheus Connector has been added to the README.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.