Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Documentation Revisions from Game Day #36

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Integrating Documentation Revisions from Game Day #36

merged 2 commits into from
Feb 28, 2024

Conversation

forestmvey
Copy link
Contributor

Summary

Integrate all changes noted in the feedback from game day.

Description

Add the following changes into the documentation for the Prometheus Connector:

  • Note lack of support for the session_token field for MFA authenticated AWS users
  • Note the format for the contents of the password file used for authenticating the AWS user in the Prometheus configuration
  • Note the requirement for needing the absolute path of the password file in the Prometheus configuration
  • Note that the deployment user policy is too long to be set inline during user creation
  • Remove global section in the example for the Prometheus configuration file
  • Add region portion to the CLI commands that create the timestream database and tables

Resolved Issues:

  • N/A

forestmvey and others added 2 commits February 23, 2024 15:38
@forestmvey
Copy link
Contributor Author

As there are no code changes in this PR and only documentation revisions which have already gone through a round of reviews, I am merging.

@forestmvey forestmvey merged commit 96dd474 into awslabs:main Feb 28, 2024
4 checks passed
@forestmvey forestmvey deleted the integ-game-day-feedback-integrations branch February 28, 2024 03:49
@forestmvey forestmvey restored the integ-game-day-feedback-integrations branch February 28, 2024 03:49
forestmvey added a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
forestmvey added a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
forestmvey added a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
forestmvey added a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant