Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Removed our deprecated correctness test suite in place of a new approach for correctness testing.
Added a new class
Mockmetheus
to send remote operations from Prometheus using snappy-encoded payloads. The previous testing approach included bringing up a Prometheus instance to seed initial testing data to run queries. This introduced conflicts as queries would fetch data from across both local and remote (Amazon Timestream) sources.Also, we had test cases that included functions and certain operators using client-side logic (which are not in scope of the Connector). It now focuses exclusively on the correctness of remote read and write operations.
Correctness tests are set up as a separate module since the underlying Prometheus dependency is using v2.5.0, and the parser was introduced as a package in a later released version.
Fixed bug where write requests without labels returned 500 instead of 422. While Prometheus always includes labels in remote writes, our Connector now handles the edge case properly.
Updated error codes to better reflect "not found" scenarios:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.