Fix ASan report about alloc/dealloc mismatch when compiled with C++23 #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
reviewed
Jun 24, 2024
There was a problem hiding this comment.
If std::allocator<T> doesn't have any virtual functions ... does that mean nothing should inherit from it?
There was a problem hiding this comment.
Discussed offline, we will backlog this for now. We should probably be using https://docs.ros.org/en/foxy/Tutorials/Advanced/Allocator-Template-Tutorial.html
| @@ -51,6 +51,10 @@ namespace Aws | |||
| return static_cast<RawPointer>(aws_mem_acquire(m_allocator, n * sizeof(T))); | |||
| } | |||
|
|
|||
| #if _LIBCPP_STD_VER > 20 | |||
There was a problem hiding this comment.
do we really need #if here?
does it really matter if we expose it in all versions of cpp standard?
There was a problem hiding this comment.
std::allocation_result was added in _LIBCPP_STD_VER > 20
This reverts commit 0948921.
DmitriyMusatkin
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Duplicate of #629 to fix lint and submodules
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.