Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up and fix for dotnet-8 #100

Merged
merged 1 commit into from
Jun 5, 2024
Merged

clean up and fix for dotnet-8 #100

merged 1 commit into from
Jun 5, 2024

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Jun 5, 2024

Issue #, if available:

https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/dotnet-pack-config
Starting for .NET SDK 8.0, the default configuration for dotnet build is Debug, while default configuration for dotnet pack is Release :)

Description of changes:

  • set configuration for build and release explicitly, for test, using Debug
  • Checked the release pipeline, we already set the configuration explicitly to Release, so that it will not affect our pipeline
  • Removed the unused codebuild scripts as we moved away from codebuild CI.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK merged commit c633d8a into main Jun 5, 2024
24 checks passed
@TingDaoK TingDaoK deleted the fix-dotnet-8 branch June 5, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants