PR updates

awslabs · Aug 26, 2024 · e14deae · e14deae
1 parent 0cd4daa
commit e14deae
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/browser/mqtt_request_response/protocol_adapter.ts b/lib/browser/mqtt_request_response/protocol_adapter.ts
@@ -461,8 +461,8 @@ export class ProtocolClientAdapter extends BufferedEventEmitter {
 
     private static isUnsubackReasonCodeRetryable(reasonCode: mqtt5.UnsubackReasonCode) : boolean {
         switch (reasonCode) {
-            case mqtt5.UnsubackReasonCode.UnspecifiedError:
             case mqtt5.UnsubackReasonCode.ImplementationSpecificError:
+            case mqtt5.UnsubackReasonCode.PacketIdentifierInUse:
                 return true;
 
             default:
@@ -472,7 +472,6 @@ export class ProtocolClientAdapter extends BufferedEventEmitter {
 
     private static isSubackReasonCodeRetryable(reasonCode: mqtt5.SubackReasonCode) : boolean {
         switch (reasonCode) {
-            case mqtt5.SubackReasonCode.UnspecifiedError:
             case mqtt5.SubackReasonCode.PacketIdentifierInUse:
             case mqtt5.SubackReasonCode.ImplementationSpecificError:
             case mqtt5.SubackReasonCode.QuotaExceeded:

diff --git a/lib/browser/mqtt_request_response/subscription_manager.ts b/lib/browser/mqtt_request_response/subscription_manager.ts
@@ -529,7 +529,7 @@ export class SubscriptionManager extends BufferedEventEmitter {
             record.status = SubscriptionStatus.Subscribed;
             this.emitEvents(record, SubscriptionEventType.StreamingSubscriptionEstablished);
         } else {
-            if (event.retryable) {
+            if (event.retryable && !this.closed) {
                 this.activateSubscription(record);
             } else {
                 record.poisoned = true;