Rollback s2n to re-enable tls13 due to s2n misconfiguration and new feature probe #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A feature probe added in v1.4.16 gates TLS13 support. The CRT consumes s2n in a way that makes feature probes unreliable (a separate issue that is being looked into), which means using that version of s2n currently disables tls13 support. By rolling back to v1.4.15, we can unblock CRT releases while we work on the long term s2n configuration issue.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.