Use Structured Logging in a More Structured Way #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In several places, empty curly braces (`{}`) were used in place of
structured logging properties. These were processed as literal
curly braces, and log context was lost. Where the value of the
property was an exception, an Exception-specialized overload was
chosen instead.
This did not alter any places where string interpolation was used
instead of structured logging properties. That could be work for
the future.
chrisoverzero
commented
Jul 27, 2021
| @@ -118,7 +118,7 @@ private Task RunSenderThread(ILoggerFactory loggerFactory) | |||
| } | |||
| catch (Exception e) | |||
| { | |||
| logger.LogWarning("Failed to write message to socket. Backing off and trying again. {}", e.Message); | |||
| logger.LogWarning(e, "Failed to write message to socket. Backing off and trying again."); | |||
| Thread.Sleep(1000); // TODO: backoff | |||
There was a problem hiding this comment.
I'm not sure this shouldn't be:
await Task.Delay(TimeSpan.FromMilliseconds(1000)).ConfigureAwait(false);…but that felt out of scope and like a Chesterton's Fence thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In several places, empty curly braces (
{}) were used in place ofstructured logging properties. These were processed as literal
curly braces in logs, and log context was lost. Where the value of
the property was an exception, an Exception-specialized overload
was chosen instead.
This did not alter any places where string interpolation was used
instead of structured logging properties. That could be work for
the future.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.