Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(new construct): aws-openapigateway-lambda #912

Merged
merged 61 commits into from
Jul 26, 2023
Merged

feat(new construct): aws-openapigateway-lambda #912

merged 61 commits into from
Jul 26, 2023

Conversation

georgebearden
Copy link
Contributor

Issue #, if available: #840

Description of changes:
Putting the README in place for the openapi-based apigateway-to-lambda construct.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@georgebearden georgebearden changed the title README for new openapi-based apigatway-to-lambda construct. feat(new construct): aws-openapigateway-lambda Mar 1, 2023
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: bf70adb
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mattiamatrix mattiamatrix mentioned this pull request Mar 2, 2023
Open
2 tasks
biffgaut
biffgaut reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@biffgaut biffgaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some quick thoughts in the few minutes I had to give it a first read.

source/patterns/@aws-solutions-constructs/aws-openapigateway-lambda/README.md Outdated Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-openapigateway-lambda/README.md Outdated Show resolved Hide resolved
alsoknownasdrew and others added 15 commits March 23, 2023 17:01
@alsoknownasdrew @georgebearden
fix(core) prevent lambda id conflict with multiple buildLambdaFunctio…
824b57f 
…n() calls in the same stack (#910)
@aws-solutions-constructs-team @georgebearden
chore(release): 2.33.0
623aaba
@biffgaut @georgebearden
chore(release prep): Update CHANGELOG.md and align-version.js
ae3d91e
@biffgaut @georgebearden
Freeze @types/node version in cdk-integ
821a054
@biffgaut @georgebearden
Freeze @types/node version in cdk-integ
26e7c28
@biffgaut @georgebearden
Update step functions integ tests
f26e8d4
@biffgaut @georgebearden
chore(core): Add warnings about using core functions from outside of …
a8c1e44 
…Solutions Constructs (#917)

* Add file header warning

* Add function header comments

* Use latest CDK to address .NET version issue

* Fix 2 typos

* One last typo
@biffgaut @georgebearden
fix(StepFunctions): Address LogGroup behavior problems (#922)
e7eb012 
* Implementation

* Clean up some code cruft
@biffgaut @georgebearden
Update package.json
4122462
@aws-solutions-constructs-team @georgebearden
chore(release): 2.34.0
7e1ccfd
@biffgaut @georgebearden
chore(release-prep): Updated CHANGELOG.md and align-version.js
2de8284
@biffgaut @georgebearden
chore(release-prep): align-version.js
720f4fd
@biffgaut @georgebearden
chore(core): migrate to assertions (#929)
26a69f3 
* First two test updates

* chore(core): migrate to assertions

* Remove old lib, final few modules
@georgebearden
Update the cloudfront-to-s3 construct to correctly set the logging bu…
c909a16 
…cket property. (#930)
@georgebearden
Update README
23ecefe
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 23ecefe
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: b391da8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 93d05bd
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

biffgaut
biffgaut requested changes May 18, 2023
View reviewed changes
Copy link
Contributor

@biffgaut biffgaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of comments and questions that might lead to changes - only a couple mandated changes.

@georgebearden
Update aws-openapigateway-lambda construct to trigger api deployments…
252963c 
… anytime the incoming api template changes or any time the lambda functions change.
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 252963c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mattiamatrix mattiamatrix mentioned this pull request Jun 16, 2023
Closed
2 tasks
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 5721230
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 59d9774
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@georgebearden
Remove integration tests that use BucketDeployment as the asset hash …
6e16923 
…of the AwsCliLayer changes outside our control.
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 6e16923
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@georgebearden
Remove integration tests that use BucketDeployment as the asset hash …
e74b89c 
…of the AwsCliLayer changes outside our control.
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: e74b89c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@georgebearden
Address pr feedback.
2a91311 
Add new template writer integration test for transforming large template with several thousand substitutions
Several new comments/documentation to make the obscure less so, hopefully>
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 2a91311
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: c2ba305
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: f742c92
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 87a88eb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

biffgaut
biffgaut reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@biffgaut biffgaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions and request to look at changing something. But pretty much done.

source/patterns/@aws-solutions-constructs/aws-openapigateway-lambda/README.md Outdated Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-openapigateway-lambda/lib/index.ts Outdated Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-openapigateway-lambda/lib/index.ts Outdated Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-openapigateway-lambda/lib/index.ts Outdated Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-openapigateway-lambda/lib/index.ts Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-openapigateway-lambda/lib/index.ts Outdated Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-openapigateway-lambda/lib/index.ts Outdated Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-openapigateway-lambda/lib/index.ts Show resolved Hide resolved
.../@aws-solutions-constructs/aws-openapigateway-lambda/test/test.openapigateway-lambda.test.ts Show resolved Hide resolved
.../patterns/@aws-solutions-constructs/resources/test/integ.template-writer-from-large-asset.ts Show resolved Hide resolved
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 1ed9b84
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@georgebearden georgebearden requested a review from biffgaut July 21, 2023 18:44
biffgaut
biffgaut requested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@biffgaut biffgaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, two comment changes. That's the last of it, promise!

source/patterns/@aws-solutions-constructs/aws-openapigateway-lambda/lib/index.ts Outdated Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-openapigateway-lambda/lib/index.ts Outdated Show resolved Hide resolved
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 43cd699
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@biffgaut biffgaut merged commit 09465d6 into main Jul 26, 2023
@biffgaut biffgaut deleted the openapigateway-to-lambda branch July 26, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biffgaut biffgaut biffgaut approved these changes

@hayesry hayesry Awaiting requested review from hayesry hayesry is a code owner

@mobri2a mobri2a Awaiting requested review from mobri2a mobri2a is a code owner

@emcfins emcfins Awaiting requested review from emcfins emcfins is a code owner

@mickychetta mickychetta Awaiting requested review from mickychetta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@georgebearden @aws-solutions-constructs-team @biffgaut @alsoknownasdrew