Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dev-env + esm support + non-compiled internal packages #3071

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

tracy-french
Copy link
Contributor

@tracy-french tracy-french commented Nov 26, 2024

Overview

This change is the start of a refactor to collocate the storybook/playwright environments across the repo (recommended by turbo) into a single development environment (i.e., @iot-app-kit/dev-env). Collocation of the envs provides:

  • Less envs to manage and align.
  • Enable whole repo development in a single place.
  • Make it easy to create stories and playwright tests for every package.

In this change, the dashboard storybook/playwright env is used as the basis of dev-env. In later changes, react-components and scene-composer stories/playwright tests will be migrated.

To build the dev-env, the following additional updates were made:

  • Using native ESM with node.js via "type": "module" setting in every package.
  • Creation of non-compiled packages with turbo repo to reuse and share code, including new dev-env, data-mocked, and helpers packages. These packages do not require a build step. Their code is built into their consumer's code.

Also includes:

  • Fix for type-fest dependency in react-components. Turns out, we don't have a direct dependency on type-fest, yet we are using it. Must be a transitive dependency letting it be imported somehow. Fix was to install it!
  • Replacement of RecursivePartial utility type with type-fest's PartialDeep.
  • Update lodash imports to use esm.

Legal

This project is available under the Apache 2.0 License.

@tracy-french tracy-french force-pushed the chore-dev-env branch 8 times, most recently from c0fee77 to 5e06448 Compare November 26, 2024 19:07
@tracy-french tracy-french changed the title chore: move dashboard dev env + msw to separate packages for reuse chore: dev-env + esm support + non-compiled internal packages Nov 26, 2024
@tracy-french tracy-french marked this pull request as ready for review November 26, 2024 19:54
@tracy-french tracy-french merged commit 3204abc into rc Nov 26, 2024
24 checks passed
@tracy-french tracy-french deleted the chore-dev-env branch November 26, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants