feat(dashboard): remove query client provider #3112
Merged
+205
−195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmbuss
force-pushed
the
feat/query-client-provider
branch
from
290cc03 to
e0c9943
Compare
chejimmy
approved these changes
Jan 22, 2025
Yes, if there was any issue, the react-queries in the dashboard would throw an error because they would have no client to make requests with. But with no issues, it should appear as if nothing has changed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove usage of the query client provider from the Dashboard components in favor of using the client singleton directly.
Legal
This project is available under the Apache 2.0 License.