[uniffi] Reintroduce async support for UniFFI #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UniFFI added support for async traits in mozilla/uniffi-rs#1981, but this is not yet released. This commit temporarily introduces a Git dependency on UniFFI to let us test the async functionality which was removed in awslabs#86. An unrelated UniFFI change (mozilla/uniffi-rs#1840) made our existing test fail.
This creates async tests for most of our sync tests.
tomleavy
approved these changes
Mar 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 89.52% 89.51% -0.02%
==========================================
Files 173 173
Lines 31404 31415 +11
==========================================
+ Hits 28114 28120 +6
- Misses 3290 3295 +5 ☔ View full report in Codecov by Sentry. |
mgeisler
commented
Mar 24, 2024
stefunctional
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #81
Description of changes:
UniFFI added support for async traits in mozilla/uniffi-rs#1981, but this is not yet released. This commit temporarily introduces a Git dependency on UniFFI to let us test the async functionality which was removed in #86.
An unrelated UniFFI change (mozilla/uniffi-rs#1840) made our existing test fail.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.