Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using key package storage trait #235

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Conversation

mulmarta
Copy link
Contributor

@mulmarta mulmarta commented Jan 9, 2025

  • Remove key package storage from config
  • Remove key package generator, use builder instead
  • In tests use TestClient which has InMemoryKeyPackage storage inside and automatically stores / finds key packages

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner January 9, 2025 15:47
@mulmarta
Copy link
Contributor Author

mulmarta commented Jan 9, 2025

CI fails due to nightly clippy problem in coverage. It'll fix itself when nightly clippy fixes itself.

tomleavy
tomleavy previously approved these changes Jan 9, 2025
@tomleavy tomleavy merged commit ea7d7f6 into 1.x-main Jan 9, 2025
30 of 32 checks passed
@tomleavy tomleavy deleted the delete-kp-storage-trait branch January 9, 2025 22:05
mulmarta added a commit that referenced this pull request Jan 14, 2025
* Delete unused code

* Stop using key package storage trait

* Fixup

* Move cipher suite into signing data

* Fix warnings after clippy update

---------

Co-authored-by: Marta Mularczyk <[email protected]>
mulmarta added a commit that referenced this pull request Jan 14, 2025
* Delete unused code

* Stop using key package storage trait

* Fixup

* Move cipher suite into signing data

* Fix warnings after clippy update

---------

Co-authored-by: Marta Mularczyk <[email protected]>
mulmarta added a commit that referenced this pull request Jan 15, 2025
* Delete unused code

* Stop using key package storage trait

* Fixup

* Move cipher suite into signing data

* Fix warnings after clippy update

---------

Co-authored-by: Marta Mularczyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants