Make CommitProcessor another variant of ReceivedMessage. #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it_processor function
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.x-main #241 +/- ##
============================================
- Coverage 90.34% 90.30% -0.04%
============================================
Files 177 177
Lines 31318 31365 +47
============================================
+ Hits 28294 28325 +31
- Misses 3024 3040 +16 ☔ View full report in Codecov by Sentry. |
tomleavy
reviewed
Jan 16, 2025
mls-rs/src/external_client/group.rs
Outdated
| #[allow(clippy::large_enum_variant)] | ||
| pub enum ExternalReceivedMessage { | ||
| /// State update as the result of a successful commit. | ||
| pub enum ExternalReceivedMessage<'a, C: ExternalClientConfig> { |
There was a problem hiding this comment.
Just food for thought, the 'a nature of this might get in the way of passing this around or storing it places. Maybe it makes more sense for the oneshot function to return simply ExternalReceivedMessage, and the non-oneshot function to return an enum that is either ExternalReceivedMessage or CommitProcessor
Comment on lines
225
to
230
| ReceivedMessage::Commit(value) => f.write_str(&format!("Commit({value:?})")), | ||
| ReceivedMessage::Proposal(value) => f.write_str(&format!("Proposal({value:?})")), | ||
| ReceivedMessage::GroupInfo(value) => f.write_str(&format!("GroupInfo({value:?})")), | ||
| ReceivedMessage::KeyPackage(value) => f.write_str(&format!("KeyPackage({value:?})")), | ||
| ReceivedMessage::Welcome => f.write_str("Welcome"), | ||
| ReceivedMessage::CommitProcessor(_) => f.write_str("CommitProcessor"), |
There was a problem hiding this comment.
Same comment as above for this, might simplify a bit
tomleavy
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.