Remove MlsRules

[mulmarta]

This looks quite big but most changes are pretty trivial.

The real change is to

• replace commit_options by appropriate functions of CommitBuilder
• introduce ProposalBuilder
• replace encryption_options by appropriate functions of CommitBuilder and ProposalBuilder

The only relevant files are

• group/mod.rs (new API)
• group/proposal.rs (ProposalBuilder)
• group/commit/builder.rs (new options for CommitBuilder)

Follow-up

• add any missing functionality to external group
• add branch / reinit builders

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 94.14484% with 38 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (51d8542) to head (3f2e8bd).

Files with missing lines	Patch %	Lines
mls-rs/src/group/proposal.rs	80.68%	28 Missing ⚠️
mls-rs/src/group/external_commit.rs	82.35%	3 Missing ⚠️
mls-rs/src/group/mod.rs	98.73%	3 Missing ⚠️
mls-rs/src/group/commit.rs	85.71%	2 Missing ⚠️
mls-rs/src/group/commit/builder.rs	98.40%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           1.x-main     #243      +/-   ##
============================================
- Coverage     90.30%   90.23%   -0.08%     
============================================
  Files           177      176       -1     
  Lines         31365    31222     -143     
============================================
- Hits          28325    28172     -153     
- Misses         3040     3050      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tomleavy]

Looks good, see nit comments. One thing we should keep in mind as we get closer to where we want to be with the API is that we need to reorg the tests at some point to be able to be at the properly level. We should have builder level tests for edge cases and then integration tests for just general protocol testing. That will make some of these files a lot smaller

[tomleavy]

Any idea why the tests above are failing? Seems like something new?

[mulmarta]

Any idea why the tests above are failing? Seems like something new?

It's new but unrelated, they fail on main too. We should investigate separately.