Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible API for AWS LC cipher suite #246

Merged
merged 4 commits into from
Jan 27, 2025
Merged

More flexible API for AWS LC cipher suite #246

merged 4 commits into from
Jan 27, 2025

Conversation

mulmarta
Copy link
Contributor

Allows to make custom cipher suites.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner January 23, 2025 14:17
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.48649% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.21%. Comparing base (539cc5c) to head (10425c5).

Files with missing lines Patch % Lines
mls-rs-crypto-awslc/src/lib.rs 86.48% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   90.19%   90.21%   +0.01%     
==========================================
  Files         180      180              
  Lines       32301    32375      +74     
==========================================
+ Hits        29134    29206      +72     
- Misses       3167     3169       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mulmarta mulmarta merged commit c5e98d2 into main Jan 27, 2025
30 checks passed
@mulmarta mulmarta deleted the awslc-api branch January 27, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants