Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on portable-atomic-* only if the target has no OS #65

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

stefunctional
Copy link
Contributor

Issues:

N/A

Description of changes:

This makes the portable-atomic* dependencies conditional on the target not having an OS.

Call-outs:

N/A

Testing:

Built

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@stefunctional stefunctional requested a review from a team as a code owner January 16, 2024 22:22
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0ae87b) 91.77% compared to head (8e75f71) 91.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   91.77%   91.79%   +0.01%     
==========================================
  Files         169      169              
  Lines       30807    30807              
==========================================
+ Hits        28273    28278       +5     
+ Misses       2534     2529       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mulmarta mulmarta merged commit 468ffc5 into main Jan 17, 2024
21 checks passed
@mulmarta mulmarta deleted the optional-portable-atomic branch January 17, 2024 11:23
@stefunctional
Copy link
Contributor Author

@mgeisler, may you check if the latest main resolves your issue regarding the portable-atomic* dependencies?

@mgeisler
Copy link
Contributor

Hi @stefunctional, wow that's very nice!

If I read this correctly, it means that the dependency will only be added bare-metal platforms? And perhaps Wasm as well? I'll test it out in AOSP again in a few days — the version I grabbed some weeks ago is okay for me to test with right now.

@stefunctional
Copy link
Contributor Author

Hi @mgeisler,

Right, portable-atomic* would only be used on targets that don't have an OS. It's not clear to me what that means for WASM.

There's a more precise cfg to test for atomic support in core at compile-time, so I opened #66 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants