Allow overriding of hardcoded DaemonSet tolerations #354
Conversation
jon-rei
requested a deployment
to
approval-gate
GitHub Actions
Waiting
| @@ -35,6 +35,12 @@ node: | |||
| limits: | |||
| memory: 256Mi | |||
| tolerateAllTaints: false | |||
| tolerations: | |||
There was a problem hiding this comment.
So with this change, if someone provides node.tolerations, it will override existing tolerations, which could be a breaking change I think. Imagine someone relies on default tolerations provided by the CSI Driver and with this change they will go away. Not sure how big is a deal this, one alternative could be creating a new variable like node.defaultTolerations for these tolerations, but then one would need to override two Helm values to tweak this configuration.
There was a problem hiding this comment.
Yes, that was also something I was thinking about.
I guess for now, creating a new value is probably the best solution without introducing a breaking change. I have now added node.defaultTolerations and put it in the else condition in tolerateAllTaints. For me this is the simplest solution after playing around with helm templating.
Resolves #348
Description of changes:
This PR will move the hardcoded tolerations from the DaemonSet template to the values,
I just used the aws-fsx-csi-driver helm chart as inspiration. As this is probably the simplest solution, it may lead to unexpected changes if someone already hastolerationsset.I have added a new value:
node.defaultTolerationsand put it in theelsecondition intolerateAllTaints.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.