Add failing reference test #1066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
Signed-off-by: Alessandro Passaro <[email protected]>
passaro
force-pushed
the
reftest-fail
branch
from
944c5b6 to
56579bc
Compare
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
added a commit
to c-hagem/mountpoint-s3
that referenced
this pull request
Dec 12, 2024
This commit addresses a case where MP model and property tests diverge (awslabs#1066). The issue was caused by the reference not correctly implementing the shadowing order defined in (#4f8cf0b)[awslabs@4f8cf0b]. Additionally, it clarifies the Semantics arising from concurrent MPUs. Signed-off-by: Christian Hagemeier <[email protected]>
c-hagem
added a commit
to c-hagem/mountpoint-s3
that referenced
this pull request
Dec 12, 2024
This commit addresses a case where MP model and property tests diverge (awslabs#1066). The issue was caused by the reference not correctly implementing the shadowing order defined in [#4f8cf0b](awslabs@4f8cf0b). Additionally, it clarifies the Semantics arising from concurrent MPUs. Signed-off-by: Christian Hagemeier <[email protected]>
c-hagem
added a commit
to c-hagem/mountpoint-s3
that referenced
this pull request
Dec 12, 2024
This commit addresses a case where MP model and property tests diverge (awslabs#1066). The issue was caused by the reference not correctly implementing the shadowing order defined in [#4f8cf0b](awslabs@4f8cf0b). Additionally, it clarifies the Semantics arising from concurrent MPUs. Signed-off-by: Christian Hagemeier <[email protected]>
c-hagem
added a commit
to c-hagem/mountpoint-s3
that referenced
this pull request
Dec 12, 2024
This commit addresses a case where MP model and property tests diverge (awslabs#1066). The issue was caused by the reference not correctly implementing the shadowing order defined in [#4f8cf0b](awslabs@4f8cf0b). Additionally, it clarifies the Semantics arising from concurrent MPUs. Signed-off-by: Christian Hagemeier <[email protected]>
|
Closing this in favour of #1201. |
c-hagem
added a commit
to c-hagem/mountpoint-s3
that referenced
this pull request
Dec 13, 2024
This commit addresses a case where MP model and property tests diverge (awslabs#1066). The issue was caused by the reference not correctly implementing the shadowing order defined in [#4f8cf0b](awslabs@4f8cf0b). Additionally, it clarifies the Semantics arising from concurrent MPUs. Signed-off-by: Christian Hagemeier <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
This commit addresses a case where MP model and property tests diverge (#1066). The issue was caused by the reference not correctly implementing the shadowing order defined in [#4f8cf0b](4f8cf0b). This commit fixes the reference model, and clarifies the semantics arising from concurrent MPUs. This is not a breaking change, as it only impacts the reference tests. This does not need a Changelog entry, as the change does not impact Mountpoint's behaviour. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Signed-off-by: Christian Hagemeier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
One of the property-based tests found a new case where the reference model and Mountpoint implementation diverge. This change adds the case as a failing test:
The issue seems to be around the shadowing behavior when a "local" file is open (i.e. not uploaded yet) and a prefix with the same name is created on the bucket. To be further investigated.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).