Add a test for an invalid cache block #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vlad Volodkin <[email protected]>
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
Signed-off-by: Vlad Volodkin <[email protected]>
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
reviewed
Nov 14, 2024
Signed-off-by: Vlad Volodkin <[email protected]>
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
reviewed
Nov 15, 2024
Signed-off-by: Vlad Volodkin <[email protected]>
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
reviewed
Nov 15, 2024
Signed-off-by: Vlad Volodkin <[email protected]>
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Signed-off-by: Vlad Volodkin <[email protected]>
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
approved these changes
Nov 15, 2024
passaro
reviewed
Nov 15, 2024
| use test_case::test_case; | ||
|
|
||
| #[cfg(all(feature = "s3_tests", feature = "s3express_tests"))] |
There was a problem hiding this comment.
not blocking: we should consider moving (some of) the use into the functions that require them (to avoid all the cfg).
| let (mount_point, _session) = mount_bucket(client.clone(), cache.clone(), &bucket, &prefix); | ||
|
|
||
| // Put an object to the mounted bucket | ||
| let object_key = generate_unprefixed_key(&prefix, "key", 100); |
There was a problem hiding this comment.
why pass the prefix then? can't you subtract the prefix's length from 100, if that's what you want?
There was a problem hiding this comment.
Actually can't we just use a fixed key here? And leave the other test where we generate the key intact?
| .await | ||
| .expect("put object must succeed"); | ||
|
|
||
| // Expect a successfull read from the source bucket. We expect cache errors being recorded because of the corrupted block. |
| @@ -1,4 +1,4 @@ | |||
| #[cfg(all(feature = "s3_tests", feature = "s3express_tests"))] | |||
| #[cfg(feature = "s3_tests")] | |||
There was a problem hiding this comment.
I think this is redundant now.
There was a problem hiding this comment.
I have to keep it to make cargo test --features fuse_tests --no-run buildable. The file only contains s3_tests so it's preferable to having multiple snippets like this in the code:
#[cfg(feature = "s3_tests")]
use crate::common::fuse::s3_session::create_crt_client;
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
## Description of change Just test improvements. Addresses comments from the #1139. Relevant issues: N/A. ## Does this change impact existing behavior? No. ## Does this change need a changelog entry in any of the crates? No. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Signed-off-by: Vlad Volodkin <[email protected]> Co-authored-by: Vlad Volodkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Just adds a test that if a block in the shared cache is invalid, it is not served to the client application.
Relevant issues: N/A
Does this change impact existing behavior?
No.
Does this change need a changelog entry in any of the crates?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).