Validate that shared cache bucket is usable #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
force-pushed
the
disable-express-cache-for-express-mount
branch
from
a7c4c91 to
83038da
Compare
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
force-pushed
the
disable-express-cache-for-express-mount
branch
from
83038da to
2b822f9
Compare
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
…ESS_ONEZONE storage class Signed-off-by: Simon Beal <[email protected]>
muddyfish
force-pushed
the
disable-express-cache-for-express-mount
branch
from
2b822f9 to
4126b4d
Compare
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
reviewed
Nov 18, 2024
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
Signed-off-by: Simon Beal <[email protected]>
muddyfish
force-pushed
the
disable-express-cache-for-express-mount
branch
from
bfad653 to
7a265f5
Compare
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
reviewed
Nov 18, 2024
| @@ -72,6 +72,33 @@ where | |||
| bucket_name: bucket_name.to_owned(), | |||
| } | |||
| } | |||
|
|
|||
| pub async fn verify_cache_valid(&self) -> ObjectClientResult<(), PutObjectError, Client::ClientError> { | |||
There was a problem hiding this comment.
nit: we can now remove the todo
Merged
muddyfish
added a commit
to muddyfish/mountpoint-s3
that referenced
this pull request
Nov 19, 2024
## Description of change - Validates the shared cache bucket is write-able - Validates the shared cache bucket supports the `EXPRESS_ONEZONE` storage class Relevant issues: N/A ## Does this change impact existing behavior? Yes, the shared cache bucket is now validated that it supports the `EXPRESS_ONEZONE` storage class ## Does this change need a changelog entry in any of the crates? No --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Signed-off-by: Simon Beal <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
## Description of change Remove unneeded todo Relevant issues: #1141 (comment) ## Does this change impact existing behavior? No ## Does this change need a changelog entry in any of the crates? No --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Simon Beal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
EXPRESS_ONEZONEstorage classRelevant issues: N/A
Does this change impact existing behavior?
Yes, the shared cache bucket is now validated that it supports the
EXPRESS_ONEZONEstorage classDoes this change need a changelog entry in any of the crates?
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).