Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for macOS builds due to pkg-config issues #1202

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

dannycjones
Copy link
Contributor

In November, macOS runners had an issue with the pkg-config package and we introduced a workaround: #1158

We see now that the fix has been released and we should no longer need the workaround: actions/runner-images#10984.

Does this change impact existing behavior?

No, CI change only.

Does this change need a changelog entry?

No.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@dannycjones dannycjones requested a review from passaro December 17, 2024 13:18
@dannycjones dannycjones temporarily deployed to PR integration tests December 17, 2024 13:18 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests December 17, 2024 13:18 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests December 17, 2024 13:18 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests December 17, 2024 13:18 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests December 17, 2024 13:18 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests December 17, 2024 13:18 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests December 17, 2024 13:18 — with GitHub Actions Inactive
Copy link
Contributor

@passaro passaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying that up!

@dannycjones dannycjones added this pull request to the merge queue Dec 17, 2024
Merged via the queue into awslabs:main with commit f09ac0c Dec 17, 2024
23 checks passed
@dannycjones dannycjones deleted the revert-pkgconf-macos-hack branch December 17, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants