Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lazy_static and once_cell with std library equivalents #1212

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

dannycjones
Copy link
Contributor

@dannycjones dannycjones commented Jan 7, 2025

The types provided by lazy_static and once_cell have now been added to the standard library as of Rust 1.80.0 (https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#lazycell-and-lazylock), and we no longer need to use these crates for this functionality. This change removes those dependencies, and updates our code to use the new standard types.

Does this change impact existing behavior?

No change in existing behavior.

Does this change need a changelog entry?

No, no behavior change.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@dannycjones dannycjones temporarily deployed to PR integration tests January 7, 2025 14:09 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests January 7, 2025 14:09 — with GitHub Actions Inactive
@dannycjones dannycjones enabled auto-merge January 7, 2025 14:09
@dannycjones dannycjones temporarily deployed to PR integration tests January 7, 2025 14:09 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests January 7, 2025 14:09 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests January 7, 2025 14:09 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests January 7, 2025 14:09 — with GitHub Actions Inactive
@dannycjones dannycjones had a problem deploying to PR integration tests January 7, 2025 14:09 — with GitHub Actions Failure
@dannycjones dannycjones disabled auto-merge January 7, 2025 14:09
@dannycjones dannycjones temporarily deployed to PR integration tests January 7, 2025 16:25 — with GitHub Actions Inactive
Copy link
Contributor

@passaro passaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dannycjones dannycjones added this pull request to the merge queue Jan 10, 2025
Merged via the queue into awslabs:main with commit 456c7de Jan 10, 2025
24 checks passed
@dannycjones dannycjones deleted the remove-once_cell-lazy_static branch January 10, 2025 16:31
keremnc pushed a commit to keremnc/mountpoint-s3 that referenced this pull request Jan 24, 2025
…bs#1212)

The types provided by `lazy_static` and `once_cell` have now been added
to the standard library as of Rust 1.80.0
(https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#lazycell-and-lazylock),
and we no longer need to use these crates for this functionality. This
change removes those dependencies, and updates our code to use the new
standard types.

### Does this change impact existing behavior?

No change in existing behavior.

### Does this change need a changelog entry?

No, no behavior change.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and I agree to the terms of
the [Developer Certificate of Origin
(DCO)](https://developercertificate.org/).

Signed-off-by: Daniel Carl Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants