Emit malloc metrics #1214
Closed
Emit malloc metrics #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
Signed-off-by: Vlad Volodkin <[email protected]>
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
vladem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
Signed-off-by: Vlad Volodkin <[email protected]>
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
added 2 commits
January 9, 2025 15:00
Signed-off-by: Vlad Volodkin <[email protected]>
Signed-off-by: Vlad Volodkin <[email protected]>
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds malloc metrics, which should help us to reason about memory wasted because of fragmentation.
Also it tunes malloc to disable dynamic MMAP_THRESHOLD, which may be the reason for fragmentation. In local tests this leads to memory being released straight away to the OS (RSS consumption is lower, strace reports
munmapbeing called after each part received fromS3GetObjectResponse.Does this change impact existing behavior?
TBD
Does this change need a changelog entry?
TBD
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).