Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebuild test integration failures #1258

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/benchmark_visualization.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ env:

jobs:
benchmark:
runs-on: ubuntu-20.04
runs-on: codebuild-soci-visualization-workflow-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-xlarge
steps:
- name: Checkout main branch
uses: actions/checkout@v4
Expand All @@ -37,7 +37,7 @@ jobs:
path: ${{github.workspace}}/benchmark/performanceTest/output/results.json

download-and-convert-benchmark-result-to-visualization-data:
runs-on: ubuntu-20.04
runs-on: codebuild-soci-visualization-workflow-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-xlarge
needs: benchmark
steps:
- name: Checkout main branch
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:

push-benchmark-result-gh-pages:
name: Push benchmark result to Github-pages
runs-on: ubuntu-20.04
runs-on: codebuild-soci-visualization-workflow-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-xlarge
needs: download-and-convert-benchmark-result-to-visualization-data
strategy:
matrix:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ env:

jobs:
test:
runs-on: ubuntu-20.04
runs-on: codebuild-soci-build-workflow-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-xlarge
timeout-minutes: 15
steps:
- uses: actions/checkout@v4
Expand All @@ -34,7 +34,7 @@ jobs:
- run: make
- run: make test
integration:
runs-on: ubuntu-20.04
runs-on: codebuild-soci-build-workflow-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-xlarge
timeout-minutes: 40
strategy:
fail-fast: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bump-deps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

# Don't bother bumping deps on forks.
if: ${{ github.repository == 'awslabs/soci-snapshotter' || github.event_name == 'workflow_dispatch' }}
runs-on: ubuntu-20.04
runs-on: codebuild-soci-bump-dependencies-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-medium

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/comparision-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ env:

jobs:
check:
runs-on: ubuntu-20.04
runs-on: codebuild-soci-comparision-test-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-xlarge
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
Expand Down
14 changes: 9 additions & 5 deletions .github/workflows/prebuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ env:

jobs:
check:
runs-on: ubuntu-20.04
runs-on: codebuild-soci-prebuild-workflow-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-small
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -32,7 +32,7 @@ jobs:
- run: PATH=$PATH:$(pwd) ./scripts/check-flatc.sh

git-secrets:
runs-on: ubuntu-20.04
runs-on: codebuild-soci-prebuild-workflow-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-small
steps:
- name: Pull latest awslabs/git-secrets repo
uses: actions/checkout@v4
Expand All @@ -54,23 +54,27 @@ jobs:
strategy:
matrix:
working_dir: ['.', 'cmd']
runs-on: ubuntu-20.04
runs-on: codebuild-soci-prebuild-workflow-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-small
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ${{ env.GO_VERSION }}
- uses: golangci/golangci-lint-action@v6
with:
version: v${{ env.GOLANGCI_LINT_VERSION }}
working-directory: ${{ matrix.working_dir }}

yamllint:
name: yamllint-lint
runs-on: ubuntu-20.04
runs-on: codebuild-soci-prebuild-workflow-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-small
steps:
- uses: actions/checkout@v4
- run: pip install yamllint
- run: yamllint .

shellcheck:
runs-on: ubuntu-20.04
runs-on: codebuild-soci-prebuild-workflow-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-small
container: koalaman/shellcheck-alpine:v0.10.0
steps:
- uses: actions/checkout@v4
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/releases.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,17 @@ permissions:

jobs:
generate-artifacts:
runs-on: ubuntu-20.04
runs-on: codebuild-soci-release-workflow-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-xlarge
env:
# Set during setup.
RELEASE_TAG: ''
DYNAMIC_BINARY_NAME: ''
STATIC_BINARY_NAME: ''
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ${{ env.GO_VERSION }}
- name: Export cleaned release tag
run: |
export release_tag=${GITHUB_REF#refs/*/} # Strip down to raw tag name
Expand Down Expand Up @@ -60,7 +63,7 @@ jobs:

validate-artifacts:
needs: generate-artifacts
runs-on: ubuntu-20.04
runs-on: codebuild-soci-release-workflow-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-xlarge
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v4
Expand All @@ -72,7 +75,7 @@ jobs:
create-release:
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
needs: [generate-artifacts, validate-artifacts]
runs-on: ubuntu-20.04
runs-on: codebuild-soci-release-workflow-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-xlarge
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-dco.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ set -eux -o pipefail

# the very first auto-commit doesn't have a DCO and the first real commit has a slightly different format. Exclude those when doing the check.
# We erreneously allowed a non-signed commit to be pushed to main.
"$(go env GOPATH)"/bin/git-validation -run DCO -range HEAD~20..HEAD
git-validation -run DCO -range HEAD~20..HEAD
3 changes: 2 additions & 1 deletion scripts/check-ltag.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ set -eux -o pipefail
CUR_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
SOCI_SNAPSHOTTER_PROJECT_ROOT="${CUR_DIR}/.."


# check ltag
pushd "${SOCI_SNAPSHOTTER_PROJECT_ROOT}"
"$(go env GOPATH)"/bin/ltag -t "${SOCI_SNAPSHOTTER_PROJECT_ROOT}/.headers" -check -v || (echo "The files listed above are missing a licence header. Please run ./scripts/add-ltag.sh"; exit 1)
ltag -t "${SOCI_SNAPSHOTTER_PROJECT_ROOT}/.headers" -check -v || (echo "The files listed above are missing a licence header. Please run ./scripts/add-ltag.sh"; exit 1)
popd