Allow insecure localhost connections #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
go
Before this change, the `docker.MatchLocalhost` function was applied to hosts retrieved from labels on snapshots, but not in the artifact fetcher. This meant that data could be lazily loaded from an insecure localhost, but we couldn't fetch the SOCI index/ztocs from an insecure localhost. This change adds the matcher to the artifact fetcher so that images can be lazily loaded from an insecure localhost. Signed-off-by: Kern Walster <[email protected]>
Kern--
force-pushed
the
insecure-localhost
branch
from
5d34cb8 to
075affe
Compare
sondavidb
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fixes #1282
Description of changes:
Before this change, the
docker.MatchLocalhostfunction was applied to hosts retrieved from labels on snapshots, but not in the artifact fetcher. This meant that data could be lazily loaded from an insecure localhost, but we couldn't fetch the SOCI index/ztocs from an insecure localhost. This change adds the matcher to the artifact fetcher so that images can be lazily loaded from an insecure localhost.Testing performed:
make test && make integrationI also did a manual test against a local
registry:2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.