Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update containerd version in workflows #1401

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

sondavidb
Copy link
Contributor

Issue #, if available:
Adjacently related to #1392

Description of changes:
Updated containerd version in CI, which should help tests pass in #1392

Testing performed:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sondavidb sondavidb requested a review from a team as a code owner October 30, 2024 07:09
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Oct 30, 2024
@sondavidb sondavidb force-pushed the update-containerd-ci branch from b016040 to 948c644 Compare October 30, 2024 07:10
austinvazquez
austinvazquez previously approved these changes Oct 30, 2024
Copy link
Contributor

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on CI pass, thanks.

@sondavidb sondavidb force-pushed the update-containerd-ci branch 2 times, most recently from 7a15345 to 1d4c96c Compare October 30, 2024 18:39
@github-actions github-actions bot added go Pull requests that update Go code testing Unit and/or integration tests labels Oct 30, 2024
@sondavidb
Copy link
Contributor Author

Had to make a tiny edit to make the TestSnapshotterSystemdStartup test case to make it more consistent.

Shubhranshu153
Shubhranshu153 previously approved these changes Oct 30, 2024
This test was flaky on newer versions of containerd, increasing the
timeout seems to make it more consistent

Signed-off-by: David Son <[email protected]>
Copy link
Contributor

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for grabbing that.

@sondavidb sondavidb merged commit cd0bd7c into awslabs:main Oct 31, 2024
17 checks passed
@sondavidb sondavidb deleted the update-containerd-ci branch February 6, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code testing Unit and/or integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants