Skip to content

Commit

Permalink
refactor: rename query to ITSChain
Browse files Browse the repository at this point in the history
  • Loading branch information
maancham committed Jan 30, 2025
1 parent ec2c7b4 commit 9ee0fd3
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 16 deletions.
4 changes: 2 additions & 2 deletions contracts/interchain-token-service/src/contract.rs
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ fn match_gateway(storage: &dyn Storage, _: &ExecuteMsg) -> Result<Addr, Report<E
#[cfg_attr(not(feature = "library"), entry_point)]
pub fn query(deps: Deps, _: Env, msg: QueryMsg) -> Result<Binary, ContractError> {
match msg {
QueryMsg::ChainConfig { chain } => {
query::chain_config(deps, chain).change_context(Error::QueryChainConfig)
QueryMsg::ITSChain { chain } => {
query::its_chain(deps, chain).change_context(Error::QueryChainConfig)
}
QueryMsg::AllItsContracts => {
query::all_its_contracts(deps).change_context(Error::QueryAllItsContracts)
Expand Down
2 changes: 1 addition & 1 deletion contracts/interchain-token-service/src/contract/query.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ pub enum Error {
State,
}

pub fn chain_config(deps: Deps, chain: ChainNameRaw) -> Result<Binary, Error> {
pub fn its_chain(deps: Deps, chain: ChainNameRaw) -> Result<Binary, Error> {
let state_config: Option<state::ChainConfig> =
state::may_load_chain_config(deps.storage, &chain).change_context(Error::State)?;
to_json_binary(&state_config.map(|config| msg::ChainConfigResponse {
Expand Down
2 changes: 1 addition & 1 deletion contracts/interchain-token-service/src/msg.rs
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ pub struct ChainConfigResponse {
pub enum QueryMsg {
/// Query the configuration registered for a chain
#[returns(Option<ChainConfigResponse>)]
ChainConfig { chain: ChainNameRaw },
ITSChain { chain: ChainNameRaw },

/// Query all registered ITS contract addresses
#[returns(HashMap<ChainNameRaw, Address>)]
Expand Down
9 changes: 3 additions & 6 deletions contracts/interchain-token-service/tests/execute.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ fn register_update_its_contract_succeeds() {
u8::MAX
));

let chain_config = assert_ok!(utils::query_chain_config(deps.as_ref(), chain.clone()));
let chain_config = assert_ok!(utils::query_its_chain(deps.as_ref(), chain.clone()));
assert_eq!(chain_config.unwrap().its_edge_contract, address);

let new_address: Address = "0x9999999990123456789012345678901234567890"
Expand All @@ -50,7 +50,7 @@ fn register_update_its_contract_succeeds() {
chain.clone(),
new_address.clone()
));
let res = assert_ok!(utils::query_chain_config(deps.as_ref(), chain.clone()));
let res = assert_ok!(utils::query_its_chain(deps.as_ref(), chain.clone()));
assert_eq!(res.unwrap().its_edge_contract, new_address);
}

Expand Down Expand Up @@ -122,10 +122,7 @@ fn register_multiple_chains_succeeds() {
assert_ok!(register_chains(deps.as_mut(), chains.clone()));

for chain in chains {
let res = assert_ok!(utils::query_chain_config(
deps.as_ref(),
chain.chain.clone()
));
let res = assert_ok!(utils::query_its_chain(deps.as_ref(), chain.chain.clone()));
assert_eq!(res.unwrap().its_edge_contract, chain.its_edge_contract);
}
}
Expand Down
8 changes: 4 additions & 4 deletions contracts/interchain-token-service/tests/query.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ fn query_chain_config() {
frozen: false,
};

let chain_config = assert_ok!(utils::query_chain_config(deps.as_ref(), chain.clone()));
let chain_config = assert_ok!(utils::query_its_chain(deps.as_ref(), chain.clone()));
utils::assert_chain_configs_match(&original_chain_config, &chain_config.unwrap());

// case sensitive query
let chain_config = assert_ok!(utils::query_chain_config(
let chain_config = assert_ok!(utils::query_its_chain(
deps.as_ref(),
"ethereum".parse().unwrap()
));
Expand All @@ -57,11 +57,11 @@ fn query_chain_config() {
new_address.clone()
));

let chain_config = assert_ok!(utils::query_chain_config(deps.as_ref(), chain.clone()));
let chain_config = assert_ok!(utils::query_its_chain(deps.as_ref(), chain.clone()));
assert_eq!(chain_config.unwrap().its_edge_contract, new_address);

let non_existent_chain: ChainNameRaw = "non-existent-chain".parse().unwrap();
let chain_config = assert_ok!(utils::query_chain_config(deps.as_ref(), non_existent_chain));
let chain_config = assert_ok!(utils::query_its_chain(deps.as_ref(), non_existent_chain));
assert_eq!(chain_config, None);
}

Expand Down
4 changes: 2 additions & 2 deletions contracts/interchain-token-service/tests/utils/query.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ use interchain_token_service::msg::{ChainConfigResponse, QueryMsg};
use interchain_token_service::{TokenConfig, TokenId, TokenInstance};
use router_api::{Address, ChainNameRaw};

pub fn query_chain_config(
pub fn query_its_chain(
deps: Deps,
chain: ChainNameRaw,
) -> Result<Option<ChainConfigResponse>, ContractError> {
let bin = query(deps, mock_env(), QueryMsg::ChainConfig { chain })?;
let bin = query(deps, mock_env(), QueryMsg::ITSChain { chain })?;
Ok(from_json(bin)?)
}

Expand Down

0 comments on commit 9ee0fd3

Please sign in to comment.