Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix floating number parsing into BigNumber #166

Merged
merged 3 commits into from
Jan 23, 2024
Merged

chore: fix floating number parsing into BigNumber #166

merged 3 commits into from
Jan 23, 2024

Conversation

npty
Copy link
Member

@npty npty commented Jan 23, 2024 •
edited
Loading

This PR will fix the following error when running test:

  1) Verify EVM Examples
       call-contract-with-token-express:
     Error: underflow [ See: https://links.ethers.org/v5-errors-NUMERIC_FAULT-underflow ] (fault="underflow", operation="BigNumber.from", value=25299.999999999996, code=NUMERIC_FAULT, version=bignumber/5.7.0)

@npty npty requested review from benjamin852 and canhtrinh January 23, 2024 09:31
@npty npty self-assigned this Jan 23, 2024
@npty npty merged commit f7cd151 into main Jan 23, 2024
4 checks passed
@npty npty deleted the fix/floating-number-parising branch January 23, 2024 15:04
@npty npty mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamin852 benjamin852 benjamin852 approved these changes

@canhtrinh canhtrinh Awaiting requested review from canhtrinh

Assignees

@npty npty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npty @benjamin852