MARP-747:Improve the explanatory dialog and pimp the documentation. #77
Conversation
ghost
requested a review
from 
…nector into feature/MARP-747-ChatGPT-assistant-Not-possible-to-mark-only-one-word-in-xhtlm-code
| private String sendRequest(String context, String question, boolean includeSystemPrompt) { | ||
| WebTarget chat = client.get().path("chat/completions"); | ||
| ArrayNode arrayNode = JsonNodeFactory.instance.arrayNode(); | ||
| arrayNode.add(message("system", SYSTEM_PROMPT)); | ||
| if (includeSystemPrompt) { | ||
| arrayNode.add(message("system", SYSTEM_PROMPT)); | ||
| } | ||
| arrayNode.add(message("user", String.format("%s \n\n %s", context, question))); | ||
| ObjectNode request = completion().set("messages", arrayNode); |
There was a problem hiding this comment.
Why no test on this rest-centered feature which is easy to re-produce in junit?
There was a problem hiding this comment.
Hi @ivy-rew
I would handle what Linh is working on from now. We are so sorry for this delay due to some critical issue regarding to marketplace website.
For the testing, we found no function from openai-assistant were tested.
Could we create a separated test project for open-ai-assistant or include it to the recent project?
There was a problem hiding this comment.
HI @ntqdinh-axonivy
Sorry this didn't reach me. Please make sure you'll use the common team chat if you receive no answer for concrete requests. Otherwise request get lost simply by me being on vacation or something alike.
Answering the question however, there are already rest-centric tests which could easily be extended: https://github.com/axonivy-market/openai-connector/blob/master/openai-connector-test/src_test/com/axonivy/connector/openai/test/AiAssistanceTest.java
... also the utility method in here could be refactored and tested very simply within the existing testing project. So I wouldn't introduce a new test-project.
There was a problem hiding this comment.
Thanks for your hint @ivy-rew
I will update the test cases for these changes soon.
|
Hi @ivy-rew |
| // Get Eclipse theme colors | ||
| Color bgColor = JFaceResources.getColorRegistry().get(JFacePreferences.CONTENT_ASSIST_BACKGROUND_COLOR); | ||
| Color fgColor = JFaceResources.getColorRegistry().get(JFacePreferences.CONTENT_ASSIST_FOREGROUND_COLOR); | ||
|
|
||
| // Create CSS with Eclipse colors | ||
| String css = String.format("body { background-color: %s; color: %s; font-family: '%s'; }", toHex(bgColor.getRGB()), | ||
| toHex(fgColor.getRGB()), JFaceResources.getTextFont().getFontData()[0].getName()); |
There was a problem hiding this comment.
the logic here is getting larger and harder to maintain, rather than adding comments,
I'd extract this CSS setup and it's colors to its own method #getEclipseCss()
- Extract dialog css set up to separated method
ntqdinh-axonivy
deleted the
feature/MARP-747-ChatGPT-assistant-Not-possible-to-mark-only-one-word-in-xhtlm-code
branch
No description provided.