-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox: prevent axios HEAD request from downloading entire original image; CSP 'upgrade-insecure-requests' handling with http-only proxies; firefox imageset listener contingent on if proxy is HTTPS #26
base: master
Are you sure you want to change the base?
Conversation
ayastreb#20 added CSPHeader replacement for Upgrade-Insecure-Requests, made MixedContentCSP header replacements case-insensitive
added axios.head config "maxContentLength:0" to prevent the head request from downloading the entire image on misconfigured servers.
Updated Axios to version 0.19 (maxContentLength bugfix) Upped version in manifast.json to 2.1.2
updated version number in package.json
… not. img srcset counts as active-mixed-content so is blocked by browser
Quick question here as I'm not very knowledgeable in this area: does setting block csp reports in ublock origin affect bandwidth hero in any way? |
I'm not too familiar with ublock, but this add-on relies heavily on CSP header manipulation to work on many secure websites. So I'd avoid messing with that |
Bandwidth hero doesn't care about, and isn't affected by CSP Reports. |
…hanged property handling to more of a case switch style
Increased timeout of the scouting HEAD request in the onBeginRequest handler.
Do not pull, there's some sort of bug that's causing a data drain, I've already maxxed out my data plan in a little over a week, and normally it takes me 3 weeks or so. I'll re-open this pull request after I've identified and fixed it. |
Is it better to disable the extension for now till this axios bug and the other unidentified data draining bug are fixed? I'm short on data in the upcoming weeks and don't want to risk it |
data draining bug only happens on my fork of the code. Even without the axios bug fix it would be a net save because it does not affect most websites. I would keep using. |
I'm 3 days into my billing cycle and it seems normal. I think the encountered data drain was just because it went into an off state due to #23. |
Note that in issue #23 images don't display at all |
Firefox-Only: Fixed HEAD requests downloading the entire original image when scouting the file-size of images on improperly configured webservers (Supposedly this also required Axios get upgraded to the latest version). Accomplished by setting {maxContentLength: 0} as config option.
The change in patchContentSecurity.js in regards to
upgrade-insecure-requests
should shut the door on #20 as far as CSP goes on http-only proxies, gawker sites (gizmodo/kotaku/io9) are improved, but still don't seem to work right. unwrappedlife.com is fixed.Once again, I didn't test on chrome, but these are pretty minor changes.
Feel free to let this one linger a bit, since if we figure out what's happening with @Tomatoide's set up I'll push the fix into this pull request assuming it doesn't have to do with the proxy they're using.