fix: fixes complex decorators not being handled #461
+237
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugop95
force-pushed
the
fix/decorators
branch
from
5a5cc5c to
f9f2a94
Compare
hugop95
force-pushed
the
fix/decorators
branch
from
f9f2a94 to
4d6bf01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460
Description
Complex decorators such as
@A.B(() => C)are currently not handled. This PR fixes this.Proposed solution
We used to get the decorator name by switch-casing on the type of decorator. It turns out to be simpler to use
sourceCode.getText(decorator), remove the first character@, and split at the first(instead.Affected rules
sort-classessort-modulessort-decoratorsWhat is the purpose of this pull request?