Changed element.remove, fixes #6

Removed fauxVideoElement, appearantly fixing #7

Gruntfile.js

@@ -66,7 +66,7 @@ module.exports = function (grunt) {
                     unused: true,
                     if_return: true,
                     join_vars: true,
-                    drop_console: false
+                    drop_console: true
                 },
                 mangle: true,
                 beautify: false

build/phaser-ads.d.ts

@@ -108,7 +108,6 @@ declare module Fabrique {
             private game;
             private adRequested;
             adManager: AdManager;
-            private fauxVideoElement;
             private resizeListener;
             constructor(game: Phaser.Game, adTagUrl: string);
             setManager(manager: AdManager): void;

package.json

@@ -1,7 +1,7 @@
 {
   "name": "phaser-ads",
   "author": "OrangeGames",
-  "version": "0.7.5",
+  "version": "0.8.0",
   "description": "A Phaser plugin for providing nice ads integration in your phaser.io game",
   "contributors": [
     {
@@ -27,7 +27,7 @@
     "grunt-contrib-uglify": "^0.11.0",
     "grunt-contrib-watch": "^0.6.1",
     "grunt-typescript": "0.8.0",
-    "phaser": "2.5.0",
+    "phaser": "2.6.1",
     "typescript": "1.8.x"
   },
   "engines": {

ts/Providers/Ima3.ts

@@ -27,8 +27,6 @@ module Fabrique {
 
             public adManager: AdManager = null;
 
-            private fauxVideoElement: HTMLMediaElement;
-
             private resizeListener: ()=> void = null;
 
             constructor(game: Phaser.Game, adTagUrl: string) {
@@ -57,19 +55,11 @@ module Fabrique {
                 this.adContent.style.height = '100%';
                 this.adContent.style.overflow = 'hidden';
 
-                //This is a work around for some ios failing issues
-                //iOS ima3 requires this information, but canvas doesn't provide it. so we create a a custom method
-                this.fauxVideoElement = this.gameContent.parentNode.appendChild(document.createElement('video'));
-                this.fauxVideoElement.id = 'phaser-ad-faux-video';
-                this.fauxVideoElement.style.position = 'absolute';
-                this.fauxVideoElement.style.zIndex = '999';
-                this.fauxVideoElement.style.display = 'none';
-
                 this.adTagUrl = adTagUrl;
                 this.game = game;
 
                 // Create the ad display container.
-                this.adDisplay = new google.ima.AdDisplayContainer(this.adContent, this.fauxVideoElement);
+                this.adDisplay = new google.ima.AdDisplayContainer(this.adContent);
 
                 //Set vpaid enabled, and update locale
                 (<any>google.ima.settings).setVpaidMode((<any>google.ima).ImaSdkSettings.VpaidMode.ENABLED);
@@ -128,22 +118,11 @@ module Fabrique {
                 adsRequest.nonLinearAdSlotWidth = width;
                 adsRequest.nonLinearAdSlotHeight = height;
 
-                if (this.game.device.iOS) {
-                    this.fauxVideoElement.style.width = width + 'px';
-                    this.fauxVideoElement.style.height = height + 'px';
-                }
-
-
                 //Required for games, see:
                 //http://googleadsdeveloper.blogspot.nl/2015/10/important-changes-for-gaming-publishers.html
                 adsRequest.forceNonLinearFullSlot = true;
 
                 try {
-                    if (this.game.device.iOS) {
-                        //We need to play the video element on click, otherwise iOS won't work :(
-                        this.fauxVideoElement.play();
-                    }
-
                     this.adRequested = true;
                     this.adLoader.requestAds(adsRequest);
                 } catch (e) {
@@ -212,9 +191,6 @@ module Fabrique {
 
                 try {
                     //Show the ad elements, we only need to show the faux videoelement on iOS, because the ad is displayed in there.
-                    if (this.game.device.iOS) {
-                        this.fauxVideoElement.style.display = 'block';
-                    }
                     this.adContent.style.display = 'block';
 
                     // Initialize the ads manager. Ad rules playlist will start at this time.
@@ -258,15 +234,6 @@ module Fabrique {
                         {
                             this.onContentResumeRequested();
                         }
-                        //Work around for skip/end not registering @ ios
-                        if (this.game.device.iOS) {
-                            let intervalId = setInterval(() => {
-                                if (this.fauxVideoElement.src.length > 0) {
-                                    this.onContentResumeRequested();
-                                    clearInterval(intervalId);
-                                }
-                            }, 200);
-                        }
                         break;
                     case google.ima.AdEvent.Type.STARTED:
                         this.adManager.onAdProgression.dispatch(Plugins.AdEvent.start);
@@ -329,9 +296,6 @@ module Fabrique {
                 }
 
                 this.adContent.style.display = 'none';
-                if (this.game.device.iOS) {
-                    this.fauxVideoElement.style.display = 'none';
-                }
                 this.adManager.onContentResumed.dispatch();
             }
 
@@ -368,10 +332,10 @@ module Fabrique {
                     if (test.offsetHeight === 0) {
                         enabled = false;
                     }
-                    test.remove();
+                    test.parentNode.removeChild(test);
 
                     return enabled;
-                }
+                };
 
                 window.setTimeout(adsEnabled = isEnabled(), 100);
 

vendor/google-ima3-sdk.d.ts

@@ -70,7 +70,7 @@ declare module GoogleAds.ima {
     }
 
     class AdDisplayContainer {
-        constructor(content: HTMLElement, ad: HTMLElement, customClickTrack?: HTMLElement);
+        constructor(content: HTMLElement, ad?: HTMLElement, customClickTrack?: HTMLElement);
         initialize(): void;
     }
 }