Merge pull request #19 from orange-games/dev

Banner release work-around
azerion · Apr 24, 2017 · 8a744f2 · 8a744f2
2 parents a18ae31 + 0317ddc
commit 8a744f2
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 9 deletions.
diff --git a/build/phaser-ads.js b/build/phaser-ads.js
diff --git a/build/phaser-ads.js.map b/build/phaser-ads.js.map
diff --git a/build/phaser-ads.min.js b/build/phaser-ads.min.js
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@orange-games/phaser-ads",
   "author": "OrangeGames",
-  "version": "2.0.8",
+  "version": "2.0.9",
   "description": "A Phaser plugin for providing nice ads integration in your phaser.io game",
   "contributors": [
     {

diff --git a/ts/Providers/Cocoon.ts b/ts/Providers/Cocoon.ts
@@ -213,7 +213,13 @@ module PhaserAds {
                 }
 
                 if (adType === CocoonAdType.banner && null !== this.banner) {
-                    this.cocoonProvider.releaseBanner(this.banner);
+                    //Releasing banners will fail on cocoon due to:
+                    // https://github.com/ludei/atomic-plugins-ads/pull/12
+                    try {
+                        this.cocoonProvider.releaseBanner(this.banner);
+                    } catch (e) {
+                        //silently ignore
+                    }
                     this.banner = null;
                     this.bannerShowable = false;
                 }