fix(Scripts/MagisterTerrace/DB) Vexallus Boss Complete Overhaul

[blinkysc]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes [Magisters Terrace] Vexallus can skip summoning Pure Energy #21258
• Closes [Magister's Terrace] Vexallus's Pure energy are not immune to AoE #21228
• Closes [Magister's Terrace] Energy Feedback does not stack from different sources #21224
• Additionally, Vexallus will now wait for all 5 Pure Energy to spawn before Spell Overload
• Clean up code so that it's more readable

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. .go c id 24744
2. use .damage to get through thresholds
3. use .damage to get under 20% observe pure energy x5 then overload
4. .die to observe proper Reset()

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[blinkysc]

I see what's going on now with problem with SPELL_OVERLOAD, for some reason UNIT_FLAG_STUNNED is applied to Vex as well... Trying to track that down

[Nyeriah]

We can't accept hacks as a viable solution to issues. Please try to figure what is wrong without using hacks.

[blinkysc]

We can't accept hacks as a viable solution to issues. Please try to figure what is wrong without using hacks.

Yeah still trying to track it down, also trying to see why the boss doesn't melee attack as well. @Nyeriah would you mind adding WIP Label? In meantime I'll put [WIP] in title

[amed80]

Looking at this video , the boss doesn't auto attack when he is in overload phase.

Also , I am not sure about this but it seems that overload spell can happen only after he reaches <20% but also it looks like it have some other aspect that need to happen first before it start casting , all the Pure energy should have been spawned already (so after the 5 summoning phases?) and it seems to need also 5? seconds after the last spawn before he start using overload which can probably explain why it's rarely happen in most videos i have seen so far.

I don't know if someone have the ability to test the boss in retail or classic 😅

[blinkysc]

Looking at this video , the boss doesn't auto attack when he is in overload phase.

Also , I am not sure about this but it seems that overload spell can happen only after he reaches <20% but also it looks like it have some other aspect that need to happen first before it start casting , all the Pure energy should have been spawned already (so after the 5 summoning phases?) and it seems to need also 5? seconds after the last spawn before he start using overload which can probably explain why it's rarely happen in most videos i have seen so far.

I don't know if someone have the ability to test the boss in retail or classic 😅

Guess it makes sense from a "flavor" perspective how the boss works. I can try adding this too. Though it seems he never melee attacks before/after commits up to this point

[Nyeriah]

Please fix the remaining broadcast_text missing issue and I will merge it and do the necessary refactor changes later. Thanks for the PR

[Nyeriah]

broadcast_text is a static table, we don't add, update or remove entries from it

SELECT * FROM broadcast_text WHERE maletext LIKE "%overloads!%";

[blinkysc]

Ahh ok, I'll change that then to 23781

[Nyeriah]

Never delete from creature_template!
Note to devs: don't edit this file, it will delete the creature if the query is reapplied!