fix(DB/Conditions): Sunwell Gates progress gossip #21344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shows gate progress when talking to Nasuun or Moorba
|
Update the branch sogla. Backtick's issue should be fixed. |
|
I am working on fixing the issue for SET :P (It is only caused due to multiple lines, but I will fix it) Was just about to comment on my PR to not merge it yet xD |
Lol, sorry man. |
Rorschach91
approved these changes
Feb 9, 2025
nl-saw
added a commit
to nl-saw/azerothcore-wotlk
that referenced
this pull request
Feb 11, 2025
* WIP grid improvements * silly mistakes * Fix include * Remove redundant AddObjectHelpers * Cleanup unused code in Grid.h * Fix crash at grid unload * Should be a continue and not a return, oops * Move GridMap structure to a new grid terrain class. Needs more structural changes * More refactoring * Misc changes/fixes * Couple missed changes * Log total map cells too * Revise how grids are naturally loaded * Load all instance grids on map create * Fix a couple missing includes on GCC * And another... * ...And another * I'll get them all eventually lol * G3d include * boop * boopv2 * boopv3 * boopv4 * boopv5 * boopv6 * boopv7 * boopv8 lol * fix(DB/Creature): Remove aggro from Abandoned Fuel Tank (azerothcore#21352) * chore(DB): import pending files Referenced commit(s): 7916db5 * fix(Core): Fix After PR#21213 Crash (azerothcore#21327) * fix(DB/Quest): Remove Failed Incursion requirement from Lost in Action (azerothcore#21353) * chore(DB): import pending files Referenced commit(s): 4fa8050 * fix(Core/Transport): Fix for passengers dropped in the middle of nowhere (azerothcore#21296) * fix(CI/Codestyle): Final fixes to backtick check (azerothcore#21361) * feat(Core/Creature): Implement HasFlagsExtra() helper to creature (azerothcore#21362) * Revert "chore(Deps/Zlib): move to Cloudflare fork (azerothcore#21028)" (azerothcore#21364) * fix(DB/SAI) add Kaylaan smart ai (azerothcore#21293) * chore(DB): import pending files Referenced commit(s): 9eeaef5 * fix(DB/Conditions): Sunwell Gates progress gossip (azerothcore#21344) Co-authored-by: sudlud <[email protected]> Co-authored-by: Rocco Silipo <[email protected]> * chore(DB): import pending files Referenced commit(s): cf103be * Some refactoring to terrain data structure * chore(DB): Add missing file extension for query. (azerothcore#21368) * fix(DB/Creature): Correct run speed of Kael'thas's Arcane Spheres on heroic. (azerothcore#21367) * chore(DB): import pending files Referenced commit(s): fcf9725 * fix(Core/Worldstate): sunsreach print correct counter (azerothcore#21356) * fix(Scripts/SunwellPleateau): Remove invincibility from human kalecgos (azerothcore#21369) * fix(Scripts/SunwellPlateau): Correct Felmyst spawn event (azerothcore#21360) * chore(DB): import pending files Referenced commit(s): 3c8823a * Another small cleanup * Fix issue with creature random movement on WMOs * Couple more updates --------- Co-authored-by: Takenbacon <[email protected]> Co-authored-by: Kitzunu <[email protected]> Co-authored-by: murmeli666 <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: 天鹿 <[email protected]> Co-authored-by: p-tkachuk <[email protected]> Co-authored-by: Andrew <[email protected]> Co-authored-by: sudlud <[email protected]> Co-authored-by: daobashun <[email protected]> Co-authored-by: Jelle Meeus <[email protected]> Co-authored-by: Rocco Silipo <[email protected]> Co-authored-by: Benjamin Jackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
shows gate progress when talking to Nasuun or Moorba
Issues Addressed:
" feat(Core/WorldState): implement Battle for Sun's Reach Event #21219
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.