fix(DB/Creature): Remove aggro from Abandoned Fuel Tank

[murmeli666]

Could not find reliable information about the usage of these. According to wowhead these have abilities so opted not to remove the SmartAi flag.

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes [Borean Tundra] Abandoned Fuel Tank are hostile. #21315

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Nyeriah]

Needs to be sniffed/checked on retail for proper npc flags

[murmeli666]

Needs to be sniffed/checked on retail for proper npc flags

Unfortunately I don't have the means to check retail or sniff. Is there a process for sniffing requests or a 'needs sniff' tag? Thanks.

[sudlud]

create object from a 49345 sniff, not sure what corresponds to flags_extra here

[0] UpdateType: CreateObject1
[0] Object Guid: Full: --- Creature/0 R4390/S7253 Map: 571 (Northrend) Entry: 27064 (Abandoned Fuel Tank) Low: ---
[0] Object Type: 5 (Unit)
[0] NoBirthAnim: False
[0] EnablePortals: False
[0] PlayHoverAnim: False
[0] HasMovementUpdate: True
[0] HasMovementTransport: False
[0] Stationary: False
[0] HasCombatVictim: False
[0] HasServerTime: False
[0] HasVehicleCreate: False
[0] HasAnimKitCreate: False
[0] HasRotation: False
[0] HasAreaTrigger: False
[0] HasGameObject: False
[0] HasSmoothPhasing: False
[0] ThisIsYou: False
[0] SceneObjCreate: False
[0] HasPlayerCreateData: False
[0] HasConversation: False
[0] MoverGUID: Full: --- Creature/0 R4390/S7253 Map: 571 (Northrend) Entry: 27064 (Abandoned Fuel Tank) Low: ---
[0] Movement Flags: 1536 (DisableGravity, Root)
[0] Movement Flags 2: 0 (None)
[0] Movement Flags 3: 0 (None)
[0] MoveTime: 1184533307
[0] Position: X: 2515.0344 Y: 6423.4165 Z: 43.354782
[0] Orientation: 5.218534469604492187
[0] Pitch: 0
[0] StepUpStartElevation: 0
[0] MoveIndex: 0
[0] Has Transport Data: False
[0] Has Fall Data: False
[0] HasSpline: True
[0] HeightChangeFailed: False
[0] RemoteTimeValid: False
[0] Has Inertia: False
[0] HasAdvFlying: False
[0] WalkSpeed: 2.5
[0] RunSpeed: 7
[0] RunBackSpeed: 4.5
[0] SwimSpeed: 4.72221994400024414
[0] SwimBackSpeed: 2.5
[0] FlightSpeed: 7
[0] FlightBackSpeed: 4.5
[0] TurnRate: 3.141592741012573242
[0] PitchRate: 3.141592741012573242
[0] MovementForceCount: 0
[0] MovementForcesModMagnitude: 1
[0] AdvFlyingAirFriction: 2
[0] AdvFlyingMaxVel: 65
[0] AdvFlyingLiftCoefficient: 1
[0] AdvFlyingDoubleJumpVelMod: 3
[0] AdvFlyingGlideStartMinHeight: 10
[0] AdvFlyingAddImpulseMaxSpeed: 100
[0] AdvFlyingMinBankingRate: 90
[0] AdvFlyingMaxBankingRate: 140
[0] AdvFlyingMinPitchingRateDown: 180
[0] AdvFlyingMaxPitchingRateDown: 360
[0] AdvFlyingMinPitchingRateUp: 90
[0] AdvFlyingMaxPitchingRateUp: 270
[0] AdvFlyingMinTurnVelocityThreshold: 30
[0] AdvFlyingMaxTurnVelocityThreshold: 80
[0] AdvFlyingSurfaceFriction: 2.75
[0] AdvFlyingOverMaxDeceleration: 7
[0] AdvFlyingLaunchSpeedCoefficient: 0.400000005960464477
[0] HasMovementSpline: True
[0] ID: 228256111
[0] Destination: X: 2515.0344 Y: 6423.4165 Z: 43.354782
[0] MovementSplineMove: False
[0] PauseTimesCount: 0
[0] FieldFlags: 4 (UnitAll)
[0] EntryID: 27064
[0] DynamicFlags: 0
[0] Scale: 1
[0] Health: 4050
[0] MaxHealth: 4050
[0] DisplayID: 24256
[0] [0] NpcFlags: 0
[0] [1] NpcFlags: 0
[0] StateSpellVisualID: 0
[0] StateAnimID: 1740
[0] StateAnimKitID: 0
[0] Charm: Full: 0x0
[0] Summon: Full: 0x0
[0] CharmedBy: Full: 0x0
[0] SummonedBy: Full: 0x0
[0] CreatedBy: Full: 0x0
[0] DemonCreator: Full: 0x0
[0] LookAtControllerTarget: Full: 0x0
[0] Target: Full: 0x0
[0] BattlePetCompanionGUID: Full: 0x0
[0] BattlePetDBID: 0
[0] (ChannelData) SpellID: 0
[0] (ChannelData) SpellXSpellVisualID: 0
[0] SummonedByHomeRealm: 0
[0] Race: 0
[0] ClassId: 1
[0] PlayerClassId: 0
[0] Sex: 2
[0] DisplayPower: 1
[0] OverrideDisplayPowerID: 0
[0] [0] Unk340: 0
[0] [0] Unk340_2: 0
[0] [1] Unk340: 0
[0] [1] Unk340_2: 0
[0] [2] Unk340: 0
[0] [2] Unk340_2: 0
[0] [3] Unk340: 0
[0] [3] Unk340_2: 0
[0] [4] Unk340: 0
[0] [4] Unk340_2: 0
[0] [5] Unk340: 0
[0] [5] Unk340_2: 0
[0] [6] Unk340: 0
[0] [6] Unk340_2: 0
[0] [0] Power: 0
[0] [0] MaxPower: 0
[0] [0] PowerRegenFlatModifier: 1
[0] [1] Power: 0
[0] [1] MaxPower: 0
[0] [1] PowerRegenFlatModifier: 1
[0] [2] Power: 0
[0] [2] MaxPower: 5
[0] [2] PowerRegenFlatModifier: 1
[0] [3] Power: 1000000
[0] [3] MaxPower: 1000000
[0] [3] PowerRegenFlatModifier: 1
[0] [4] Power: 0
[0] [4] MaxPower: 0
[0] [4] PowerRegenFlatModifier: 1
[0] [5] Power: 0
[0] [5] MaxPower: 0
[0] [5] PowerRegenFlatModifier: 1
[0] [6] Power: 0
[0] [6] MaxPower: 0
[0] [6] PowerRegenFlatModifier: 1
[0] Level: 70
[0] EffectiveLevel: 0
[0] ContentTuningID: 0
[0] ScalingLevelMin: 0
[0] ScalingLevelMax: 0
[0] ScalingLevelDelta: 0
[0] ScalingFactionGroup: 0
[0] ScalingHealthItemLevelCurveID: 0
[0] ScalingDamageItemLevelCurveID: 0
[0] FactionTemplate: 2022
[0] (VirtualItems) [0] ItemID: 0
[0] (VirtualItems) [0] ItemAppearanceModID: 0
[0] (VirtualItems) [0] ItemVisual: 0
[0] (VirtualItems) [1] ItemID: 0
[0] (VirtualItems) [1] ItemAppearanceModID: 0
[0] (VirtualItems) [1] ItemVisual: 0
[0] (VirtualItems) [2] ItemID: 0
[0] (VirtualItems) [2] ItemAppearanceModID: 0
[0] (VirtualItems) [2] ItemVisual: 0
[0] Flags: 33554432
[0] Flags2: 2099200
[0] Flags3: 0
[0] AuraState: 0
[0] [0] AttackRoundBaseTime: 2000
[0] [1] AttackRoundBaseTime: 2000
[0] BoundingRadius: 1
[0] CombatReach: 0
[0] DisplayScale: 1
[0] NativeDisplayID: 24256
[0] NativeXDisplayScale: 1
[0] MountDisplayID: 0
[0] StandState: 0
[0] PetTalentPoints: 0
[0] VisFlags: 0
[0] AnimTier: 0
[0] PetNumber: 0
[0] PetNameTimestamp: 0
[0] PetExperience: 0
[0] PetNextLevelExperience: 2147483647
[0] ModCastingSpeed: 1
[0] ModSpellHaste: 1
[0] ModHaste: 1
[0] ModRangedHaste: 1
[0] ModHasteRegen: 1
[0] ModTimeRate: 1
[0] CreatedBySpell: 0
[0] EmoteState: 0
[0] TrainingPointsUsed: 0
[0] TrainingPointsTotal: 0
[0] [0] ResistanceBuffModsPositive: 54
[0] [0] ResistanceBuffModsNegative: 0
[0] [1] ResistanceBuffModsPositive: 0
[0] [1] ResistanceBuffModsNegative: 0
[0] [2] ResistanceBuffModsPositive: 0
[0] [2] ResistanceBuffModsNegative: 0
[0] [3] ResistanceBuffModsPositive: 0
[0] [3] ResistanceBuffModsNegative: 0
[0] [4] ResistanceBuffModsPositive: 0
[0] [4] ResistanceBuffModsNegative: 0
[0] [5] ResistanceBuffModsPositive: 0
[0] [5] ResistanceBuffModsNegative: 0
[0] [6] ResistanceBuffModsPositive: 0
[0] [6] ResistanceBuffModsNegative: 0
[0] BaseMana: 0
[0] SheatheState: 1
[0] PvpFlags: 0
[0] PetFlags: 0
[0] ShapeshiftForm: 0
[0] HoverHeight: 1
[0] MinItemLevelCutoff: 0
[0] MinItemLevel: 0
[0] MaxItemLevel: 0
[0] WildBattlePetLevel: 0
[0] BattlePetCompanionNameTimestamp: 0
[0] InteractSpellID: 0
[0] ScaleDuration: 100
[0] LooksLikeMountID: 0
[0] LooksLikeCreatureID: 0
[0] LookAtControllerID: -1
[0] GuildGUID: Full: 0x0
[0] SkinningOwnerGUID: Full: 0x0

[sudlud]

the tanks also have aura 50162 (Fuel Tank Aggro), which is set in AC in creature_addon correctly, not sure of this is related / relevant for the issue

[Nyeriah]

Unit flags 33554432 is unselectable, unselectable creatures dont aggro

[Nyeriah]

I am only seeing this

azerothcore-wotlk/src/server/game/Entities/Creature/Creature.cpp

Line 2520 in ff4d1ef

if (HasUnitFlag(UNIT_FLAG_NON_ATTACKABLE | UNIT_FLAG_NOT_SELECTABLE) || IsImmuneToNPC())

but I think I remember seeing it elsewhere, but anyway flags_extra is a custom flag (civilian) and I think can be used here since they don't seem to have any other flag that prevents combat from that sniff