Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npc_services_00.sql #25

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Update npc_services_00.sql #25

merged 1 commit into from
Sep 5, 2024

Conversation

jempson
Copy link
Contributor

@jempson jempson commented Aug 3, 2024

Corrected insert statements to match the current database format separating creature_template_model information into it's own insert statement.

Changes Proposed:

  • Current database world database format breaks the model information out into it's own table.

Issues Addressed:

SOURCE:

Tests Performed:

  • tested on Debian 12 and AzerothCore rev. ee8c103d3d9b 2024-08-02 19:21:21 +0000 (master branch) (Unix, RelWithDebInfo, Static)

How to Test the Changes:

  1. On a fresh deploy of AzerothCore import the sql file.

Corrected insert statements to match the current database format separating creature_template_model information into it's own insert statement.
@jempson
Copy link
Contributor Author

jempson commented Aug 13, 2024

Is this something I need to work on? My code was just an sql change no code changes on my end.

@Helias Helias closed this Aug 15, 2024
@Helias Helias reopened this Aug 15, 2024
@Helias
Copy link
Member

Helias commented Aug 15, 2024

the CI gave this error :/, I understand that you change consists of only SQL changes, but we should fix this

[ 20%] Building CXX object src/server/game/CMakeFiles/game.dir/AI/CreatureAIRegistry.cpp.o
/home/runner/work/mod-npc-services/mod-npc-services/modules/mod-npc-services/src/npc_services.cpp:48:39: fatal error: no member named 'SendNotification' in 'WorldSession'
   48 |                 player->GetSession()->SendNotification("You are in combat!");
      |                 ~~~~~~~~~~~~~~~~~~~~  ^
1 error generated.
gmake[2]: *** [modules/CMakeFiles/modules.dir/build.make:90: modules/CMakeFiles/modules.dir/mod-npc-services/src/npc_services.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:1199: modules/CMakeFiles/modules.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....

@Helias Helias merged commit 14e13af into azerothcore:master Sep 5, 2024
1 check failed
@Helias
Copy link
Member

Helias commented Sep 5, 2024

the error have been fixed, thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants