Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npc_services.cpp Sept 2024 Fix #26

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

Sephing
Copy link
Contributor

@Sephing Sephing commented Sep 5, 2024

Minor code changes to fix ACore no longer building with this module

Changes Proposed:

-Added #include Chat.h
-SendNotification now uses ChatHandler

Issues Addressed:

  • Sept 2024 Azeroth Core Update would not build due to error while building this module

Tests Performed:

  • Build completed with these changes

Added #include Chat.h
SendNotification now uses ChatHandler
@Helias Helias merged commit cc83ffb into azerothcore:master Sep 5, 2024
1 check failed
@Helias
Copy link
Member

Helias commented Sep 5, 2024

thanks for your PR!

@Sephing Sephing deleted the patch-1 branch September 5, 2024 12:52
@Sephing Sephing restored the patch-1 branch September 5, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants