Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added depends_on with condition & fixed dependency reorder algorithm #302

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

tcorzo
Copy link

@tcorzo tcorzo commented Aug 5, 2024

This pull request adds support for unmarshal of the depends_on field with conditions. It also includes a fix for the dependency reorder algorithm. The changes allow direct import of compose files with dependency condition fields and fixes false positives regarding circular dependencies. The code has been tested with various scenarios and includes unit tests to verify the functionality.
Notes:

  • Conditions are not considered when starting the containers, they're just succesfully unmarshalled.
  • There are a lot of formatting changes, I can take the time to revert them in case they make the PR too annoying to read

Copy link

cla-bot bot commented Aug 5, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: tcorzo.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Aug 5, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA.

@tcorzo
Copy link
Author

tcorzo commented Aug 5, 2024

Omg the conditions are already implemented on unstable 🤦‍♂️ I think the circular dependencies bug is still present though, I'll check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant