Fixes and refactoring #19
Conversation
|
Hahahahahaha, this pull request is quite substantial! 😂 |
|
Your pull request is indeed quite extensive. If possible, could you please divide it into several smaller pull requests for submission? If it's not convenient, I'll go ahead and merge it. Any subsequent issues can be addressed in follow-up fixes. In any case, thank you very much for the significant contribution of time and effort you've made. 💞 |
|
I noticed that you might have missed some specific checks, for instance, https://github.com/b-yp/logseq-link-to-local/pull/19/files#diff-1cd8b18798a1a103bfe13bef54354c1f3a3bea29a31c8eea1a0c67a3a839b811L65. Therefore, I'm hesitant to merge hastily, primarily due to the substantial size of this pull request. Is it possible to break it down into smaller parts? |
|
Hi! I don't think I can break this down as I basically modified everything. Could you please test it for some corner cases and maybe modify the code if something's wrong? (you have rights to modify this PR) |
In this PR I rewrote core logic, making code more straightforward. Feel free to propose any adjustments