V13 #4
Open
V13 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmack
reviewed
Jan 23, 2025
| @@ -75,13 +66,6 @@ public function processDatamap_preProcessFieldArray(&$incomingFieldArray, $table | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * See what tags are already in the database and add missing tags, and map the tag names to the IDs. | |||
There was a problem hiding this comment.
comments like this aren't bad actually ;)
| @@ -10,12 +12,18 @@ | |||
| * of the License, or any later version. | |||
| */ | |||
|
|
|||
| /** | |||
| * Helper functionality to quickly work with tags without having to configure TCA, this also allows for "tag" | |||
| * to change implementation without having users to modify their code. | |||
There was a problem hiding this comment.
comments like this aren't bad actually ;)
| @@ -53,12 +65,6 @@ public function buildFieldConfiguration(string $table, string $fieldName, array | |||
| return $fieldConfiguration; | |||
| } | |||
|
|
|||
| /** | |||
| * Shorthand function to identify all fields that have tags based on the foreign_table field. | |||
There was a problem hiding this comment.
comments like this aren't bad actually ;)
|
|
||
| /** | ||
| * Abstraction layer to keep all tag DB queries within this PHP class. |
There was a problem hiding this comment.
comments like this aren't bad actually ;)
| return $conn->lastInsertId(); | ||
| } | ||
|
|
||
| /** | ||
| * Simple query for looking for tags that contain the search word. No multi-word / and/or search implemented yet. |
There was a problem hiding this comment.
comments like this aren't bad actually ;)
| use TYPO3\CMS\Core\Utility\StringUtility; | ||
|
|
||
| /** | ||
| * Render a list of tags. |
There was a problem hiding this comment.
comments like this aren't bad actually ;)
| } | ||
|
|
||
| /** | ||
| * DataHandler hook to create tags automatically if they don't exist yet. This way, a clean list of | ||
| * IDs is entered to DataHandler. |
There was a problem hiding this comment.
comments like this aren't bad actually ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.