Skip to content

Commit

Permalink
Prevent boon sim from parseing negatives and added to settings for 10…
Browse files Browse the repository at this point in the history
…s/30s graphs
  • Loading branch information
baaron4 committed Jun 19, 2018
1 parent f0e9d11 commit 67beb06
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 18 deletions.
4 changes: 2 additions & 2 deletions LuckParser/App.config
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@
<value>True</value>
</setting>
<setting name="Show10s" serializeAs="String">
<value>True</value>
<value>True</value>
</setting>
<setting name="Show30s" serializeAs="String">
<value>True</value>
<value>True</value>
</setting>
</LuckParser.Properties.Settings>
</userSettings>
Expand Down
8 changes: 6 additions & 2 deletions LuckParser/Models/ParseModels/Players/AbstractPlayer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,12 @@ private void setBoonDistribution(BossData bossData, SkillData skillData, List<Co

for (int i = start; i <= end; i++)
{
toFill[i] = new Point(i, simul.getStack(i));
toFillPresence[i] = new Point(i, simul.getItemDuration() > 0 ? 1 : 0);
if (i >= 0)

This comment has been minimized.

Copy link
@EliphasNUIT

EliphasNUIT Jun 19, 2018

Collaborator

I have a cleaner fix for this in my maintenance branch (PR soon), the real issue was in getBoonMap() where we considered stuff outside of the fight

{
toFill[i] = new Point(i, simul.getStack(i));
toFillPresence[i] = new Point(i, simul.getItemDuration() > 0 ? 1 : 0);
}

}
}
// reduce precision to seconds
Expand Down
22 changes: 8 additions & 14 deletions LuckParser/Properties/Settings.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions LuckParser/Properties/Settings.settings
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,11 @@
<Setting Name="ParsePhases" Type="System.Boolean" Scope="User">
<Value Profile="(Default)">True</Value>
</Setting>
<Setting Name="Show10s" Type="System.Boolean" Scope="User">
<Value Profile="(Default)">True</Value>
</Setting>
<Setting Name="Show30s" Type="System.Boolean" Scope="User">
<Value Profile="(Default)">True</Value>
</Setting>
</Settings>
</SettingsFile>

0 comments on commit 67beb06

Please sign in to comment.