Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudo: EndBlock for BTC staking contract #14

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

SebastianElvis
Copy link
Collaborator

@SebastianElvis SebastianElvis commented Jun 13, 2024

Test plan: make test-e2e

Copy link

@gusin13 gusin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm ✅

}

// send the sudo call
return k.doSudoCall(ctx, addr, msg)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iiuc this is how cosmwasm enabled chains would interact with the deployed contract? doSudoCall triggers wasmvm somehow and transmits the message?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. This is how Go code sends a certain message to a certain contract. Since the Go code developers define who and how these messages are sent, those messages are kind of privileged, therefore called "sudo calls"

Copy link

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SebastianElvis SebastianElvis merged commit 9d22dbd into main Jun 14, 2024
1 of 4 checks passed
@SebastianElvis SebastianElvis deleted the endblock-msg branch June 14, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants