Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Babylon contracts #15

Merged
merged 4 commits into from
Jun 19, 2024
Merged

bump Babylon contracts #15

merged 4 commits into from
Jun 19, 2024

Conversation

SebastianElvis
Copy link
Collaborator

@SebastianElvis SebastianElvis commented Jun 18, 2024

@SebastianElvis SebastianElvis requested a review from maurolacy June 18, 2024 10:19
Copy link

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this still requires adjustment, as one level of nesting was removed from the begin / end block sudo defs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can now update these blobs to the just released v0.7.0 tag. https://github.com/babylonchain/babylon-contract/releases/tag/v0.7.0-rc.0

@SebastianElvis SebastianElvis merged commit cac4ac9 into main Jun 19, 2024
1 of 4 checks passed
@SebastianElvis SebastianElvis deleted the bump-contract branch June 19, 2024 06:44
@@ -1 +1 @@
938124458cdfdcd1b7b6bf14762ef606447c3c89
ed2bb75d109c579ad9b1e8ad1efe089421326028

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You can put the version tag here. The download_releases.sh script does that for you. Will check that it works.

Copy link

@maurolacy maurolacy Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The download_releases.sh script works fine. I run it like this:

GITHUB_API_TOKEN="$BBN_GITHUB_API_TOKEN" ./download_releases.sh v0.7.0-rc.0

Where BBN_GITHUB_API_TOKEN contains a token with access to the babylon-contract repo.

@maurolacy
Copy link

CI is not passing, btw.

@SebastianElvis
Copy link
Collaborator Author

CI is not passing, btw.

CI for this repo is broken as github action could not fetch private repositories. Asked infra team for help and they will do sth depending on the priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants